Multi tool use

PHP query using an association from another query

I am trying to INSERT into my SQL table in PHP using an association I already returned from a previous SELECT query. But the compiler is giving me a syntax error 'unexpected $EOF'.

Essentially, this is what I am doing:

$query2 = "SELECT * FROM users WHERE user_name='$user.username'";
$result2 = mysqli_query($db, $query2);
$new_user = mysqli_fetch_assoc($result2);

$query3 = "INSERT INTO new_table (new_user_id) VALUES('$new_user['user_id']');";
mysqli_query($db, $query3);


Query 3 is the one giving me the error. I have referenced variables like this before with the fetch association. I'm incredibly new to PHP, but isn't that fetch by association just creating a dictionary? Any ideas?

Thanks,

$user.username

$user->username

$user['username']

$new_user['user_id']

{}

{$new_user['user_id']}

2 Answers
2

Looks like the issue is with the single quote marks in the code below:

VALUES('$new_user['user_id']')


If you were to set a variable outside of the query like this it should work:

$user_id = $new_user['user_id'];
$query3 = "INSERT INTO new_table (new_user_id) VALUES('$user_id');";


I would also suggest you parameterize your queries.

The EOF error is short for end of file which means the PHP doesn't think your script ends where you think it does. This is usually caused by a control block not being closed e.g. {...code ?> with no closing }.

EOF

end of file

{...code ?>

}

You have some other issues that should be address. You shouldn't use variables in queries. You can't use a quoted index in a string. You don't need to execute 2 queries to do what you are trying to do.

INSERT INTO new_table (new_user_id) SELECT user_id FROM users WHERE user_name= ?


Should be work. Use that with prepare, bind_param, and execute and your code will be much more secure.

prepare

bind_param

execute

You also can read more about these concepts here, http://php.net/manual/en/mysqli.quickstart.prepared-statements.php.

Also if interested in how that SQL query works see this https://dev.mysql.com/doc/refman/8.0/en/insert-select.html.

By clicking "Post Your Answer", you acknowledge that you have read our updated terms of service, privacy policy and cookie policy, and that your continued use of the website is subject to these policies.